Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Display emoji in visual format and enable send icon on emoji selection #663

Merged
merged 2 commits into from
Nov 10, 2024

Conversation

SinghaAnirban005
Copy link
Contributor

@SinghaAnirban005 SinghaAnirban005 commented Nov 9, 2024

Brief Title

Fix emoji display format and enable send icon on emoji selection

Acceptance Criteria fulfillment

  • Emoji should display in visual format within the input box on selection.
  • Send icon should be enabled upon selecting an emoji.

Fixes #662

Video/Screenshots

EmbeddedChat._.Simple.-.Simple.Storybook.and.1.more.page.-.Personal.-.Microsoft.Edge.2024-11-09.12-24-25.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-663 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@Spiral-Memory
Copy link
Collaborator

Hey @SinghaAnirban005,
There might be a simpler fix for this. The logic is already defined in the onTextChange event; the only issue is that clicking an emoji from the box isn’t triggering this event. See if you can use the existing code and just make this event trigger.

@SinghaAnirban005
Copy link
Contributor Author

Sure @Spiral-Memory i will look into it !!!

@SinghaAnirban005
Copy link
Contributor Author

@Spiral-Memory I have solely used the onTextChange function to handle the parsing rather than creating separate function for it using the pre-existing code

@Spiral-Memory
Copy link
Collaborator

Spiral-Memory commented Nov 10, 2024

Yaa looks much better than before..

I just wanna know, why exactly onTextChange is not getting triggered automatically ? I mean by clicking that on that emoji, it is causing the input text box to change right ? Can't we fix that from there itself ?

@SinghaAnirban005
Copy link
Contributor Author

That function is only getting triggered when an user tries to write an input in the message Box and no triggering takes place on simply selecting the emoji .
image
In the above function when emoji is selected i have ensured a trigger is initialized .In the original code even though the messageRef holds the emoji , It simply doesnt't trigger the onTextChange function due to which it which it fails to parse the emoji

@Spiral-Memory
Copy link
Collaborator

LGTM! Great work @SinghaAnirban005
Thanks for the fix

@Spiral-Memory Spiral-Memory merged commit afa6b81 into RocketChat:develop Nov 10, 2024
4 checks passed
github-actions bot added a commit that referenced this pull request Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Emoji Selection Displays in Descriptive Format and Send Icon Disabled
2 participants