Skip to content

feat: Enhance add link modal and disabling message items while typing #809

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 23 commits into
base: develop
Choose a base branch
from
Open

feat: Enhance add link modal and disabling message items while typing #809

wants to merge 23 commits into from

Conversation

thepiyush-303
Copy link
Contributor

@thepiyush-303 thepiyush-303 commented Jan 5, 2025 •
edited
Loading

Brief Title

Enhance add link modal including proper css making it more user friendly, and when we write something it should disable items such as Audio recorder, video recorder and upload file option.

  • also the blurriness of emojis are fixed in this PR by removing some css and majorly by not converting emojis in images instead directly send them in Html with their unicode, converting emojis to images is still done for emojis not containing unicode for e.g the emojis which are send to us from other side.

Acceptance Criteria fulfillment

  • Improving Add Link Modal - adding link icon, giving label
  • Disabling Audio/video/file options in toolbar while typing
  • pressing outside of the modal or clicking 'esc' should close the modal.
  • change the labels to what RC follows
  • fixing emoji blurring.
  • fix emoji handling logic.

Fixes #808

Video/Screenshots

Screencast.from.2025-02-08.09-23-19.mp4

PR Test Details

Note: The PR will be ready for live testing at https://rocketchat.github.io/EmbeddedChat/pulls/pr-809 after approval. Contributors are requested to replace <pr_number> with the actual PR number.

@dhairyashiil
Copy link
Contributor

Please attach a video/screenshot of the Add Link modal as well.

@thepiyush-303
Copy link
Contributor Author

Please attach a video/screenshot of the Add Link modal as well.

It's already shown in the screencast attached above

@dhairyashiil
Copy link
Contributor

Please attach a video/screenshot of the Add Link modal as well.

It's already shown in the screencast attached above

Got it. Can we remove the placeholders? Since you added labels, users will know what to type inside them.

Regarding the labels, since it's a Link Window and we're only interacting with the link (not any other functionality), users will understand that the 'Text' and 'URL' refer to the link. There's no need to specifically label them as 'Link Text' and 'Link URL'.

Also, I think it would be nice to stay consistent with Rocket.Chat channel terminology, using only 'Text' and 'URL'.

@thepiyush-303
Copy link
Contributor Author

Got it!
Will commit soon.

@Spiral-Memory
Copy link
Collaborator

Resolve conflicts

@thepiyush-303
Copy link
Contributor Author

@Spiral-Memory

Done.

@thepiyush-303 thepiyush-303 marked this pull request as draft February 5, 2025 13:09
@thepiyush-303 thepiyush-303 marked this pull request as ready for review February 7, 2025 11:02
@thepiyush-303
Copy link
Contributor Author

Hello @Spiral-Memory
Let me know if blurriness of emojis is a valid issue .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhance Add Link Modal and disable audio/video/file messages on typing
3 participants
@thepiyush-303 @dhairyashiil @Spiral-Memory