feat: New Deno runtime #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-gubert
force-pushed
the
feat/deno-runtime
branch
from
1907229
to
4a4640f
Compare
Co-authored-by: Douglas Gubert <[email protected]>
d-gubert
force-pushed
the
feat/deno-runtime
branch
from
51e6ed1
to
6231a21
Compare
d-gubert
commented
Jun 13, 2024
d-gubert
commented
Jun 13, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What? ⛵
Adding a runtime that isolates app execution in a Deno subprocess
Why? 🤔
Since VM2 has been discontinued due to vulnerabilities, we need to replace it
Links 🌎
https://adr.rocket.chat/0055
PS 👀
ARCH-1144
This the main "feature PR" - functionality will mostly be added by other "child PRs". You can see them mentioned in their merge commit titles in the commit list below
The full implementation will require some changes on Rocket.Chat side. These are the PRs from that repo:
RocketChat/Rocket.Chat#31136
RocketChat/Rocket.Chat#31395
RocketChat/Rocket.Chat#31821