-
Notifications
You must be signed in to change notification settings - Fork 794
feat: Adding the Translator language: "TAMIL" #3118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
feat: Adding the Translator language: "TAMIL" #3118
Conversation
Added Tamil language for Language translation. - Complete Tamil translation for all UI elements - Follows Rocket.Chat localization standards - Covers all dialog boxes, menus, and settings"
- Complete Tamil translation for all UI elements - Follows Rocket.Chat localization standards - Covers all dialog boxes, menus, and settings"
|
|
WalkthroughThis change removes the asset-building pipeline and several UI asset/icon components, deletes the video call window module, and adds Tamil (ta) localization. It also updates the i18n resource map to lazily load the new locale. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant UI as UI
participant I18N as i18n resources
participant Loader as Dynamic Import
Note over UI,I18N: New/updated control flow for Tamil locale loading
UI->>I18N: request strings for locale 'ta'
I18N->>Loader: import('./ta.json')
activate Loader
Loader-->>I18N: resolve ta.json
deactivate Loader
I18N-->>UI: return resource bundle
sequenceDiagram
autonumber
participant Main as Main/IPC
participant VCW as VideoCallWindow (Removed)
participant WV as <webview> (Removed)
rect rgba(255, 230, 230, 0.4)
Note over Main,VCW: Previous flow (now removed)
Main->>VCW: open with URL via IPC
VCW->>WV: load URL, attach listeners
WV-->>VCW: load / error / crash events
VCW->>VCW: auto-recovery (reload/refresh/reinit)
VCW-->>Main: close or ready signals
end
Note over Main: Module and flow removed
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/i18n/ta.json (1)
121-121: Verify spacing around punctuation.Two minor formatting observations:
- Line 121:
"{{- url }} ."has a space before the period- Line 150:
" ரத்து"has a leading spaceThese may be intentional for Tamil language formatting rules, but please verify they render correctly in the UI.
Also applies to: 150-150
src/i18n/resources.ts (1)
5-5: Import path is correct; no change required
Optionally renamesrc/i18n/ta.jsontota.i18n.jsonto align with other locale filenames.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Jira integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (8)
src/buildAssets.ts(0 hunks)src/i18n/resources.ts(1 hunks)src/i18n/ta.json(1 hunks)src/ui/assets/DmgBackground.tsx(0 hunks)src/ui/assets/NsisSideBar.tsx(0 hunks)src/ui/components/RocketChatLogo.tsx(0 hunks)src/ui/icons/WindowsTrayIcon.tsx(0 hunks)src/videoCallWindow/videoCallWindow.tsx(0 hunks)
💤 Files with no reviewable changes (6)
- src/ui/icons/WindowsTrayIcon.tsx
- src/ui/assets/NsisSideBar.tsx
- src/ui/components/RocketChatLogo.tsx
- src/videoCallWindow/videoCallWindow.tsx
- src/ui/assets/DmgBackground.tsx
- src/buildAssets.ts
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx}
📄 CodeRabbit inference engine (CLAUDE.md)
**/*.{ts,tsx}: Follow existing TypeScript patterns with strict mode enabled
All new code must pass ESLint and TypeScript checks
Avoid unnecessary comments; only add comments for complex logic or non-obvious decisions
Files:
src/i18n/resources.ts
🔇 Additional comments (1)
src/i18n/ta.json (1)
1-441: LGTM! Comprehensive Tamil translation with proper placeholder handling.This complete Tamil localization file correctly:
- Maintains all required placeholder tokens ({{- appName}}, {{- version}}, {{- host}}, {{- url}}, {{count}}, etc.)
- Follows the same JSON structure as other locale files
- Covers all major UI sections (context menus, dialogs, downloads, settings, errors, etc.)
- Uses proper Tamil Unicode characters throughout
The translation appears thorough and well-formatted, enabling Rocket.Chat.Electron access for Tamil speakers.
|
@pavin7512 Thanks for your PR, but why all the removals? The new language its a very cool add, fix the PR and I will accept it. |
Adds complete Tamil language translation for Rocket.Chat.Electron desktop application, making it accessible to Tamil-speaking users worldwide.
Description of changes
src/i18n/ta.jsonwith 500+ translated stringsMotivation and Context
Tamil is spoken by over 78 million people worldwide and is an official language in Sri Lanka, Singapore, and India. This translation:
Screenshots
Technical Details
src/i18n/ta.json{{appName}},{{version}}Testing Performed
Checklist
Impact
Related Issues
This addresses the need for broader language support in Rocket.Chat ecosystem.
Summary by CodeRabbit
New Features
Refactor
Chores