Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apps): Adds a toast message dispatcher to the apps #30171

Closed
wants to merge 10 commits into from

Conversation

tiagoevanp
Copy link
Contributor

@tiagoevanp tiagoevanp commented Aug 24, 2023

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Depends on: RocketChat/Rocket.Chat.Apps-engine#657

AECO-203

@changeset-bot
Copy link

changeset-bot bot commented Aug 24, 2023

⚠️ No Changeset found

Latest commit: ce42d27

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #30171 (ce42d27) into develop (dcfb771) will decrease coverage by 0.12%.
The diff coverage is 25.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #30171      +/-   ##
===========================================
- Coverage    50.44%   50.32%   -0.12%     
===========================================
  Files          819      819              
  Lines        15208    15212       +4     
  Branches      2770     2770              
===========================================
- Hits          7671     7656      -15     
- Misses        7115     7133      +18     
- Partials       422      423       +1     
Flag Coverage Δ
e2e 48.13% <25.00%> (-0.14%) ⬇️
unit 57.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tiagoevanp tiagoevanp marked this pull request as ready for review August 26, 2023 19:31
@casalsgh casalsgh requested a review from csuadev August 28, 2023 12:49
csuadev
csuadev previously approved these changes Aug 28, 2023
@tiagoevanp tiagoevanp added the stat: ready to merge PR tested and approved waiting for merge label Aug 30, 2023
@tassoevan tassoevan added this to the 6.4.0 milestone Aug 30, 2023
tassoevan
tassoevan previously approved these changes Aug 30, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 30, 2023
@dionisio-bot dionisio-bot bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 30, 2023
@ggazzo
Copy link
Member

ggazzo commented Aug 30, 2023

I want to paraphrase a famous friend of mine: this will go wrong

@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 30, 2023
@tiagoevanp tiagoevanp dismissed stale reviews from csuadev and tassoevan via 7f28a8f August 30, 2023 17:32
@tiagoevanp tiagoevanp requested review from a team as code owners August 30, 2023 17:32
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 30, 2023
tassoevan
tassoevan previously approved these changes Aug 30, 2023
@tiagoevanp tiagoevanp removed the stat: ready to merge PR tested and approved waiting for merge label Aug 30, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 30, 2023
@kodiakhq kodiakhq bot removed the stat: ready to merge PR tested and approved waiting for merge label Aug 30, 2023
@kodiakhq
Copy link
Contributor

kodiakhq bot commented Aug 30, 2023

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: conflict labels Aug 31, 2023
@dionisio-bot dionisio-bot bot added stat: ready to merge PR tested and approved waiting for merge and removed stat: ready to merge PR tested and approved waiting for merge labels Aug 31, 2023
@tiagoevanp tiagoevanp modified the milestones: 6.4.0, 6.5.0 Aug 31, 2023
@tiagoevanp tiagoevanp removed the stat: ready to merge PR tested and approved waiting for merge label Aug 31, 2023
@dionisio-bot dionisio-bot bot added the stat: ready to merge PR tested and approved waiting for merge label Aug 31, 2023
@tiagoevanp
Copy link
Contributor Author

tiagoevanp commented Aug 31, 2023

Need important changes in PR and apps-engine code to proceed! Not sure yet if this PR should be closed.

@tiagoevanp tiagoevanp marked this pull request as draft August 31, 2023 19:35
@tiagoevanp
Copy link
Contributor Author

Closing this one in favor of new solution proposal.

@tiagoevanp tiagoevanp closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stat: QA skipped stat: ready to merge PR tested and approved waiting for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants