feat(fuselage-forms): Create Package - Form utility wrappers for a11y compliance #1670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ee017c5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
gabriellsh
changed the title
|
There's a build error hapenning right now due to a missing dependency on root. This was not caused by this PR, so I'll open it for review. |
tassoevan
previously approved these changes
Jul 18, 2025
tassoevan
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes (including videos or screenshots)
Create the new package
fuselage-forms.This package contains utility wrappers to facilitate implementing forms with proper a11y compliance.
The components in this package are wrapped
@rocket.chat/fuselagecomponents that handle most (if not all) a11y necessities of forms. It does so by leveraging react contexts, allowing Labels and Descriptors to "self-register", and Inputs inform the Field of what type they are. Unique ID's are generated for each field, and the labelling strategy varies depending on the rendered input.In summary, for most cases, it should only be needed to change the import of
FieldandInputcomponents from@rocket.chat/fuselageto@rocket.chat/fuselage-forms. Then you just need to remove any manual IDs and references to them, such as removingaria-labelledby,htmlFor,id, etc.Issue(s)
ARCH-1657
Further comments