StarWars5e - NPC Layout Improvement

[BE-Arbiter]

Submission Checklist

Required

• The pull request title clearly contains the name of the sheet I am editing.
• The pull request title clearly states the type of change I am submitting (New Sheet/New Feature/Bugfix/etc.).
• The pull request makes changes to files in only one sub-folder.
• The pull request does not contain changes to any json files in the translations folder (translation.json is permitted)

Changes / Description

• Split design in two column
• Allow to link npc traits to chat
• Leading spaces corrections (Sorry about that)

Testing URL : https://app.roll20.net/join/17737343/0TAFzQ

[roll20deploy]

Character Sheet Info Roll20 Internal Use only.

[BE-Arbiter]

@Anduh Second try :')
I have provided a test-game for the changes.
I tried to get the Sw5e discord to react but as of now no one has reacted.

[Anduh]

I'll see if I have time checking this over the weekend. If not, likely be the weekend after that.

If I haven't commented on this by Sunday at same o'clock, feel free to ping me again.

[NorWhal]

Hey @Anduh

Tagging you here for a follow-up! The usual wait period we have is three weeks of no response. Please let us know if you need more time.

Nora

[Anduh]

Yeah I need time, hadn't found the time to review this properly, so was kicking it down the lane.
Should find the time to test it propely within the next 9 days.

[BE-Arbiter]

@Anduh Thank you :)

[kfroll20]

Hello @Anduh,

Tagging you for another follow-up. Have you had a chance to take a look at this PR? Please let us know if we can move forward with merging these changes.

Thank you!

[BE-Arbiter]

Unfortunately not yet.
I'm trying to have the rest of the community to have a look in the test game but, as fast as they were complaining when I broke something, there is not much activity to prevent the brokenness to happens =D

[NorWhal]

We've made this PR a draft while y'all are still in the testing phase of this project. Once @BE-Arbiter has finished with those tests and marked this as ready for review again, we’ll be looking to move forward with merging this PR. @Anduh if you have time to weigh in, we’d appreciate your insight, but we’ll merge as soon as Arbiter is happy with the testing.

[BE-Arbiter]

I am personally happy with the tests I made. I'm just not sure it's good practice x').

[Anduh]

will take a look this weekend

[NorWhal]

If there's no objections from @BE-Arbiter, we'll be merging this next Monday to give @Anduh one last weekend for review

[BE-Arbiter]

No objections