Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to set RPM #10

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

carycode
Copy link

@carycode carycode commented Jun 7, 2017

A function to set RPM seems like a common thing people would want to do.
(Also capital-A Arduino, so it works on case-sensitive operating systems
such as Linux)

seems like a common thing people would want to do.
(Also capital-A Arduino, so it works on case-sensitive operating systems
such as Ubuntu)
Copy link
Owner

@RollingGecko RollingGecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the code. It is OK. But I can not test it. can you verify successful testing?
Why did you multiply rpm with 1000?

@imartinezl
Copy link
Contributor

This pull request #9 includes this function as well

@eduardsik
Copy link

Hi, how can I read the motor temp. over uart? I dont find the solution even in Vedder's documentation, just fet and pcb temp. Could you implement it please?

@Peemouse
Copy link

Hi, this value is included in COMM_GET_VALUES command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants