Skip to content

Issues/32 - Can automatically find template based on pointing, sca, band or image_path #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 31 commits into from
Jul 25, 2025

Conversation

wmwv
Copy link
Contributor

@wmwv wmwv commented Jul 18, 2025

Adds the ability for the following three to work.

Closes #32

python detect_supernova/pipeline.py --pointing 53526 --sca 1 --band R062 --template-pointing 5044 --template-sca 8 --template-band R062 -o /dia_out_dir
python detect_supernova/pipeline.py --pointing 53526 --sca 1 --band R062 -o /dia_out_dir

or just by passing the image path

image_path=/dvs_ro/cfs/cdirs/lsst/shared/external/roman-desc-sims/Roman_data/RomanTDS/images/simple_model/R062/53526/Roman_TDS_simple_model_R062_53526_1.fits.gz
python detect_supernova/pipeline.py --science-path ${image_path} -o /dia_out_dir

The functions that support this are all in util.py, which could be moved to snappl in the future.

wmwv added 29 commits July 14, 2025 14:57
@wmwv wmwv requested a review from a team as a code owner July 18, 2025 19:37
@wmwv wmwv requested review from chernya4 and laldoroty and removed request for a team July 18, 2025 19:37
@wmwv
Copy link
Contributor Author

wmwv commented Jul 18, 2025

@chernya4 Could you verify that you can run the examples in the README.md in this PR?
@laldoroty What do you think of this design? Which of the util.py functions would be useful to move to snappl?

@laldoroty
Copy link

I think it looks great. Though I think that all/nearly all of utils.py would make sense in snappl? It seems like it's largely image metadata retrieval with some OpenUniverse stuff baked in. This would help keep OU invisible to detect_supernova/sidecar.

@wmwv
Copy link
Contributor Author

wmwv commented Jul 25, 2025

Agreed, all of util.py should go into snappl.

@wmwv wmwv merged commit 8bd2e0d into main Jul 25, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New Feature]: Add ability to take image file or pointing,sca,band on command line and find matching image
2 participants