Skip to content

feat: allow trigger of dao-dapp-automation workflow #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

feat: allow trigger of dao-dapp-automation workflow #1008

wants to merge 15 commits into from

Conversation

david-iov
Copy link
Collaborator

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 28, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails
actions/actions/github-script 60a0d83039c74a4aee543508d2ffcb1c3799cdea 🟢 7.2
Details
CheckScoreReason
Packaging⚠️ -1packaging workflow not detected
Code-Review🟢 10all changesets reviewed
Binary-Artifacts🟢 10no binaries found in the repo
Maintained🟢 68 commit(s) and 0 issue activity found in the last 90 days -- score normalized to 6
Dangerous-Workflow🟢 10no dangerous workflow patterns detected
CII-Best-Practices⚠️ 0no effort to earn an OpenSSF best practices badge detected
Token-Permissions🟢 9detected GitHub workflow tokens with excessive permissions
Pinned-Dependencies⚠️ 1dependency not pinned by hash detected -- score normalized to 1
Fuzzing⚠️ 0project is not fuzzed
Signed-Releases⚠️ -1no releases found
License🟢 10license file detected
Security-Policy🟢 9security policy file detected
Branch-Protection⚠️ -1internal error: error during GetBranch(releases/v2): error during branchesHandler.query: internal error: githubv4.Query: Resource not accessible by integration
SAST🟢 10SAST tool is run on all commits
Vulnerabilities🟢 55 existing vulnerabilities detected

Scanned Files

  • .github/workflows/trigger-e2e-tests.yml

javicoin
javicoin reviewed May 28, 2025
View reviewed changes
javicoin
javicoin approved these changes May 28, 2025
View reviewed changes
Copy link

@javicoin javicoin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@david-iov david-iov force-pushed the davidiov/trigger-workflow branch from dc1fb5e to 973640e Compare May 29, 2025 11:44
@javicoin javicoin requested a review from antomor May 29, 2025 12:03
antomor
antomor reviewed Jun 3, 2025
View reviewed changes
antomor
antomor reviewed Jun 3, 2025
View reviewed changes
.github/workflows/trigger-e2e-tests.yml Outdated
steps:
- name: Trigger E2E Tests in Target Repo
id: trigger
uses: actions/github-script@v7
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should specify the commit here

antomor
antomor reviewed Jun 3, 2025
View reviewed changes
@david-iov david-iov force-pushed the davidiov/trigger-workflow branch from 858b709 to d436d83 Compare June 9, 2025 12:51
antomor
antomor reviewed Jun 30, 2025
View reviewed changes
.github/workflows/cr.qa.deploy.yaml
environment: CR-QA
test_type: smoke
secrets:
token: ${{ secrets.DAO_DAPP_AUTOMATION_PAT }}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this isn't currently set

antomor
antomor approved these changes Jun 30, 2025
View reviewed changes
Copy link
Collaborator

@antomor antomor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@david-iov @javicoin the env secrets still need to be set, but apart from that LGTM.

@jurajpiar jurajpiar added the collective-rewards PRs that touch CR parts label Jul 16, 2025
@antomor antomor added dao PRs made by DAO team devops PRs that require Devops attention labels Aug 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antomor antomor antomor approved these changes

@javicoin javicoin javicoin approved these changes

Assignees
No one assigned
Labels
collective-rewards PRs that touch CR parts dao PRs made by DAO team devops PRs that require Devops attention
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@david-iov @antomor @javicoin @jurajpiar