TOK-870: fix allocation sliders #1273
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
jurajpiar
force-pushed
the
TOK-870/backing_cards_fix
branch
8 times, most recently
from
6e53b31 to
7b47c4b
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR fixes allocation sliders to represent the ratio of available stRIF only, as part of TOK-870. The changes refactor the allocation system from a spread prop pattern to a more structured approach with explicit backing state management.
- Refactors BuilderCard and AllocationInput components to use structured props instead of spread syntax
- Updates allocation logic to properly calculate available backing based on stRIF balance and existing allocations
- Removes unused components (TotalBackingMetric, AvailableBackingMetric) and consolidates their functionality into inline components
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/components/TokenAmountDisplay/TokenAmountDisplay.tsx | Reorders imports and adds TODO comment for actions prop |
| src/app/shared/components/BuildersSpotlight/BuildersSpotlight.tsx | Changes from spread props to explicit builder prop |
| src/app/shared/components/BuilderCard/BuilderCardControl.tsx | Major refactor to use structured backing state props instead of individual allocation props |
| src/app/shared/components/BuilderCard/BuilderCard.tsx | Updates component interface to accept structured props and removes internal state management |
| src/app/shared/components/BuilderCard/BuilderCard.stories.tsx | Updates stories to match new component interface with structured backing state |
| src/app/backing/components/index.ts | Removes all exports (component cleanup) |
| src/app/backing/components/TotalBackingMetric/* | Removes entire component and its stories |
| src/app/backing/components/Spotlight/Spotlight.tsx | Updates to use new builder prop pattern |
| src/app/backing/components/AvailableBackingMetric/* | Removes entire component and its stories |
| src/app/backing/components/AllocationInput/AllocationInput.tsx | Major refactor to handle structured backing state and fix slider calculations |
| src/app/backing/components/AllocationInput/AllocationInput.stories.tsx | Updates stories to match new component interface |
| src/app/backing/BackingPage.tsx | Inlines removed components and updates allocation distribution logic |
jurajpiar
force-pushed
the
TOK-870/backing_cards_fix
branch
5 times, most recently
from
a276498 to
ae2d530
Compare
…ilable strif only cleanup moving alocation metrics component to backing page make allocationInput free of context fixes allocs input value fix(backing): allows slider to pick all
jurajpiar
force-pushed
the
TOK-870/backing_cards_fix
branch
2 times, most recently
from
39f281d to
ca47afe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes allocation sliders to represent the ratio of available stRIF, only.