TOK-819: naming refactor and stories fix #1283
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
jurajpiar
changed the title
jurajpiar
force-pushed
the
TOK-819/builderTableRefactor
branch
from
9234d5e to
7f88b61
Compare
- rename allocations to backingShares
jurajpiar
force-pushed
the
TOK-819/builderTableRefactor
branch
3 times, most recently
from
9200b7d to
d747e8d
Compare
jurajpiar
changed the title
jurajpiar
force-pushed
the
TOK-819/builderTableRefactor
branch
from
d747e8d to
a8a5045
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the naming from "allocations" to "backingShare" throughout the codebase and fixes action cell stories to improve text visibility.
- Renames all references from "allocations" to "backingShare" for better naming consistency
- Updates component names, interfaces, and properties to use the new naming convention
- Creates new BackingShareCell component to replace AllocationCell
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| TableColumnDropdown.stories.tsx | Updates column ID from 'allocations' to 'backingShare' in test data |
| BackingShareCell/index.ts | New barrel export file for BackingShareCell component |
| BackingShareCell/BackingShare.tsx | Renamed component with updated interface and property names |
| BackingShareCell/BackingShare.stories.tsx | Updated Storybook configuration for renamed component |
| AllocationCell/index.ts | Removed old AllocationCell barrel export |
| BuildersTable.tsx | Updated sorting logic and column visibility checks for new naming |
| BuilderTable.config.ts | Updated column configuration and labels for backingShare |
| BuilderHeaderRow.tsx | Updated header cell reference to use new column ID |
| BuilderDataRow.tsx | Comprehensive update of component usage and variable names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.