Tidying: ObjectParamAdd() always returns an empty list.

So assigning the result of ObjectParamAdd() is not useful.
RotherOSS · Feb 2, 2024 · 43bdbec · 43bdbec
1 parent 8b834c0
commit 43bdbec
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/Kernel/Modules/AgentTicketBounce.pm b/Kernel/Modules/AgentTicketBounce.pm
@@ -222,10 +222,10 @@ sub Run {
         }
 
         # get template generator object
-        my $TemplateGenerator = $Kernel::OM->ObjectParamAdd(
+        $Kernel::OM->ObjectParamAdd(
             'Kernel::System::TemplateGenerator' => { %{$Self} }
         );
-        $TemplateGenerator = $Kernel::OM->Get('Kernel::System::TemplateGenerator');
+        my $TemplateGenerator = $Kernel::OM->Get('Kernel::System::TemplateGenerator');
 
         # prepare salutation
         $Param{Salutation} = $TemplateGenerator->Salutation(

diff --git a/Kernel/Modules/AgentTicketBulk.pm b/Kernel/Modules/AgentTicketBulk.pm
@@ -888,14 +888,13 @@ sub Run {
                     my $Customer   = $Recipients[0];
 
                     # get template generator object
-                    my $CustomerUserObject      = $Kernel::OM->Get('Kernel::System::CustomerUser');
-                    my $TemplateGeneratorObject = $Kernel::OM->ObjectParamAdd(
+                    my $CustomerUserObject = $Kernel::OM->Get('Kernel::System::CustomerUser');
+                    $Kernel::OM->ObjectParamAdd(
                         'Kernel::System::TemplateGenerator' => {
                             CustomerUserObject => $CustomerUserObject,
                         },
                     );
-
-                    $TemplateGeneratorObject = $Kernel::OM->Get('Kernel::System::TemplateGenerator');
+                    my $TemplateGeneratorObject = $Kernel::OM->Get('Kernel::System::TemplateGenerator');
 
                     # generate sender name
                     my $From = $TemplateGeneratorObject->Sender(

diff --git a/Kernel/System/ObjectManager.pm b/Kernel/System/ObjectManager.pm
@@ -393,10 +393,10 @@ sub ObjectInstanceRegister {
 
 =head2 ObjectParamAdd()
 
-Adds arguments that will be passed to constructors of classes
-when they are created, in the same format as the C<L<new()>> method
-receives them. Existing constructor arguments are overwritten. Already
-existing constructor arguments are kept.
+Merge the arguments that will be passed to constructors of classes
+when they are created. The format in the same as for the C<L<new()>> method
+of the objects. Existing constructor arguments are overwritten. Already
+existing constructor arguments, that are not in the new list,  are kept.
 
     $Kernel::OM->ObjectParamAdd(
         'Kernel::System::Ticket' => {
@@ -407,6 +407,8 @@ existing constructor arguments are kept.
         },
     );
 
+Always returns an empty list.
+
 =cut
 
 sub ObjectParamAdd {