Issue #2921: perlimports check for Kernel::System::DateTime

RotherOSS · Feb 3, 2024 · 6bd15b6 · 6bd15b6
1 parent 954d3bf
commit 6bd15b6
Show file tree

Hide file tree

Showing 13 changed files with 50 additions and 23 deletions.
diff --git a/Kernel/Modules/AgentTicketPrint.pm b/Kernel/Modules/AgentTicketPrint.pm
@@ -19,7 +19,11 @@ package Kernel::Modules::AgentTicketPrint;
 use strict;
 use warnings;
 
-use Kernel::System::DateTime;
+# core modules
+
+# CPAN modules
+
+# OTOBO modules
 use Kernel::System::VariableCheck qw(IsHashRefWithData);
 use Kernel::Language              qw(Translatable);
 

diff --git a/Kernel/Output/HTML/Dashboard/TicketStatsGeneric.pm b/Kernel/Output/HTML/Dashboard/TicketStatsGeneric.pm
@@ -19,7 +19,12 @@ package Kernel::Output::HTML::Dashboard::TicketStatsGeneric;
 use strict;
 use warnings;
 
-use Kernel::System::DateTime qw(:all);
+# core modules
+
+# CPAN modules
+
+# OTOBO modules
+use Kernel::System::DateTime qw(OTOBOTimeZoneGet);
 
 our $ObjectManagerDisabled = 1;
 

diff --git a/Kernel/Output/HTML/Notification/AgentTimeZoneCheck.pm b/Kernel/Output/HTML/Notification/AgentTimeZoneCheck.pm
@@ -21,8 +21,13 @@ use parent 'Kernel::Output::HTML::Base';
 use strict;
 use warnings;
 
-use Kernel::Language qw(Translatable);
-use Kernel::System::DateTime;
+# core modules
+
+# CPAN modules
+
+# OTOBO modules
+use Kernel::Language         qw(Translatable);
+use Kernel::System::DateTime ();
 
 our @ObjectDependencies = (
     'Kernel::Config',

diff --git a/Kernel/Output/HTML/Notification/CustomerUserTimeZoneCheck.pm b/Kernel/Output/HTML/Notification/CustomerUserTimeZoneCheck.pm
@@ -21,8 +21,13 @@ use parent 'Kernel::Output::HTML::Base';
 use strict;
 use warnings;
 
-use Kernel::Language qw(Translatable);
-use Kernel::System::DateTime;
+# core modules
+
+# CPAN modules
+
+# OTOBO modules
+use Kernel::Language         qw(Translatable);
+use Kernel::System::DateTime ();
 
 our @ObjectDependencies = (
     'Kernel::Config',

diff --git a/Kernel/Output/HTML/Preferences/TimeZone.pm b/Kernel/Output/HTML/Preferences/TimeZone.pm
@@ -19,8 +19,13 @@ package Kernel::Output::HTML::Preferences::TimeZone;
 use strict;
 use warnings;
 
-use Kernel::Language qw(Translatable);
-use Kernel::System::DateTime;
+# core modules
+
+# CPAN modules
+
+# OTOBO modules
+use Kernel::Language         qw(Translatable);
+use Kernel::System::DateTime ();
 
 our @ObjectDependencies = (
     'Kernel::Config',

diff --git a/Kernel/Output/HTML/Statistics/View.pm b/Kernel/Output/HTML/Statistics/View.pm
@@ -27,7 +27,7 @@ use warnings;
 
 # OTOBO modules
 use Kernel::System::VariableCheck qw(:all);
-use Kernel::System::DateTime;
+use Kernel::System::DateTime      ();
 
 our @ObjectDependencies = (
     'Kernel::Config',

diff --git a/Kernel/System/DateTime.pm b/Kernel/System/DateTime.pm
@@ -15,8 +15,8 @@
 # --
 
 package Kernel::System::DateTime;
+
 ## nofilter(TidyAll::Plugin::OTOBO::Perl::Time)
-## nofilter(TidyAll::Plugin::OTOBO::Perl::Translatable)
 
 use v5.24;
 use strict;
@@ -40,9 +40,9 @@ use Scalar::Util qw(looks_like_number);
 use List::Util   qw(none);
 
 # CPAN modules
-use DateTime 1.08;    # need 1.08 because Kernel::System::DateTime overrides _core_time()
-use DateTime::TimeZone;
-use DateTime::Locale;
+use DateTime 1.08      ();    # need 1.08 because Kernel::System::DateTime overrides _core_time()
+use DateTime::TimeZone ();
+use DateTime::Locale   ();
 
 # OTOBO modules
 use Kernel::System::VariableCheck qw( IsArrayRefWithData IsHashRefWithData );

diff --git a/Kernel/System/Log.pm b/Kernel/System/Log.pm
@@ -28,8 +28,8 @@ use Carp ();
 use Try::Tiny;
 
 # CPAN modules
-use DateTime 1.08;
-use DateTime::Locale;
+use DateTime 1.08 ();
+use DateTime::Locale ();
 
 # OTOBO modules
 

diff --git a/Kernel/System/SupportDataCollector/Plugin/OTOBO/TimeSettings.pm b/Kernel/System/SupportDataCollector/Plugin/OTOBO/TimeSettings.pm
@@ -19,12 +19,15 @@ package Kernel::System::SupportDataCollector::Plugin::OTOBO::TimeSettings;
 use strict;
 use warnings;
 
+use parent qw(Kernel::System::SupportDataCollector::PluginBase);
+
+# core modules
 use POSIX;
 
-use parent qw(Kernel::System::SupportDataCollector::PluginBase);
+# CPAN modules
 
+# OTOBO modules
 use Kernel::Language qw(Translatable);
-use Kernel::System::DateTime;
 
 our @ObjectDependencies = (
     'Kernel::Config',

diff --git a/Kernel/System/Web/InterfaceAgent.pm b/Kernel/System/Web/InterfaceAgent.pm
@@ -28,8 +28,8 @@ use Time::HiRes ();
 # CPAN modules
 
 # OTOBO modules
-use Kernel::Language qw(Translatable);
-use Kernel::System::DateTime;
+use Kernel::Language         qw(Translatable);
+use Kernel::System::DateTime ();
 
 our @ObjectDependencies = (
     'Kernel::Config',

diff --git a/Kernel/System/Web/InterfaceCustomer.pm b/Kernel/System/Web/InterfaceCustomer.pm
@@ -30,7 +30,7 @@ use Time::HiRes ();
 # OTOBO modules
 use Kernel::System::VariableCheck qw(IsArrayRefWithData IsHashRefWithData);
 use Kernel::Language              qw(Translatable);
-use Kernel::System::DateTime;
+use Kernel::System::DateTime      ();
 
 our @ObjectDependencies = (
     'Kernel::Config',

diff --git a/bin/psgi-bin/otobo.psgi b/bin/psgi-bin/otobo.psgi
@@ -84,7 +84,7 @@ use File::Basename qw(dirname);
 use File::Path     qw(make_path);
 
 # CPAN modules
-use DateTime 1.08;
+use DateTime 1.08 ();               ## no perlimports
 use Template ();
 use Plack::Builder;
 use Plack::Request;

diff --git a/scripts/test/DateTime.t b/scripts/test/DateTime.t
@@ -23,12 +23,12 @@ use utf8;
 # core modules
 
 # CPAN modules
-use DateTime;
+use DateTime ();
 use Test2::V0;
 
 # OTOBO modueles
 use Kernel::System::UnitTest::RegisterOM;    # Set up $Kernel::OM
-use Kernel::System::DateTime;
+use Kernel::System::DateTime ();
 
 my $ConfigObject = $Kernel::OM->Get('Kernel::Config');