Update parameters usage

.github/workflows/WinX64.yml

@@ -97,7 +97,7 @@ jobs:
         uses: Minionguyjpro/[email protected]
         with:
           path: .\Build\install.iss
-          options: /O+ /DMyAppVersion=${{steps.get-version.outputs.file-version}} /DMyAppOutputDir=${{ steps.paths.outputs.output_dir }} /DMyAppExeName=PicView${{steps.get-version.outputs.file-version}}.exe /DMyAppIcon=${{ github.workspace }}\src\PicView.Avalonia.Win32\icon.ico /DMyAppLicenseFile=${{ github.workspace }}\src\PicView.Core\Licenses\LICENSE.txt
+          options: /O+ /version=${{steps.get-version.outputs.file-version}} /outputDir=${{ steps.paths.outputs.output_dir }} /appExe=PicView${{steps.get-version.outputs.file-version}}.exe /appIcon=${{ github.workspace }}\src\PicView.Avalonia.Win32\icon.ico /appLicense=${{ github.workspace }}\src\PicView.Core\Licenses\LICENSE.txt
 
       # Step 11: Upload the Inno Setup Installer as an artifact
       - name: Upload Inno Setup Installer

Build/install.iss

@@ -1,42 +1,35 @@
-#define MyAppName "PicView"
-#define MyAppVersion "{#MyAppVersion}"
-#define MyAppVersionInfo "{#MyAppVersionInfo}"
-#define MyAppPublisher "Ruben2776"
-#define MyAppExeName "{#MyAppExeName}"
-#define AppIcon "{#MyAppIcon}"
-#define LicenseFile "{#MyAppLicenseFile}"
-
 [Setup]
 AppId={{F102E394-0FA6-4AEA-826D-9FE699115BAB}
-AppName={#MyAppName}
-AppVersion={#MyAppVersion}
-AppPublisher={#MyAppPublisher}
+AppName={param:appName|PicView}
+AppVersion={param:version|1.0}
+AppPublisher="Ruben2776"
 AppPublisherURL=https://picview.org/
 AppSupportURL=https://github.com/Ruben2776/PicView/issues
 AppUpdatesURL=https://picview.org/download
 DefaultDirName={sd}\PicView
 DisableProgramGroupPage=yes
-LicenseFile={#LicenseFile}
+LicenseFile={param:appLicense|license.txt}
 PrivilegesRequired=lowest
-OutputDir={#MyAppOutputDir}
-OutputBaseFilename={#MyAppName}-{#MyAppVersion}
-SetupIconFile={#AppIcon}
+OutputDir={param:outputDir|/}
+OutputBaseFilename={param:appName|PicView}-{param:version|1.0}
+SetupIconFile={param:appIcon|icon.ico}
 Compression=lzma
 SolidCompression=yes
 WizardStyle=modern
-UninstallDisplayIcon={app}\{#MyAppExeName}
-UninstallDisplayName={#MyAppName}
+UninstallDisplayIcon={app}\{param:appExe|PicView.exe}
+UninstallDisplayName={param:appName|PicView}
 ChangesAssociations=yes
+VersionInfoVersion={param:version|1.0}
 
 [Files]
-Source: "{#MyAppOutputDir}\*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs createallsubdirs
+Source: "{param:outputDir|/}\*"; DestDir: "{app}"; Flags: ignoreversion recursesubdirs createallsubdirs
 
 [Icons]
-Name: "{autoprograms}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"
-Name: "{autodesktop}\{#MyAppName}"; Filename: "{app}\{#MyAppExeName}"; Tasks: desktopicon
+Name: "{autoprograms}\{param:appName|PicView}"; Filename: "{app}\{param:appExe|PicView.exe}"
+Name: "{autodesktop}\{param:appName|PicView}"; Filename: "{app}\{param:appExe|PicView.exe}"; Tasks: desktopicon
 
 [Run]
-Filename: "{app}\{#MyAppExeName}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent
+Filename: "{app}\{param:appExe|PicView.exe}"; Description: "{cm:LaunchProgram,{#StringChange(MyAppName, '&', '&&')}}"; Flags: nowait postinstall skipifsilent
 
 #include 'uninstallPrev.iss'
 #include 'registry.iss'