Refactor dead code lint #4294
Open
Refactor dead code lint #4294
+46
−54
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasly-ba
force-pushed
the
dead-code
branch
6 times, most recently
from
fba4e7c to
e223a3b
Compare
This patch is simple, it only moves the check of unused static items and unused const items into the dead-code scan visitor. gcc/rust/ChangeLog: * checks/lints/rust-lint-scan-deadcode.h: Warns if there is an unused static item or unused const item. * checks/lints/unused/rust-unused-checker.cc (UnusedChecker::visit): Removes static item and const item. * checks/lints/unused/rust-unused-checker.h: Same here. gcc/testsuite/ChangeLog: * rust/compile/static_item_0.rs: Change warning description. * rust/compile/const_item_0.rs: New test. Signed-off-by: Lucas Ly Ba <lucas.ly-ba@outlook.com>
P-E-P
reviewed
Jan 12, 2026
| @@ -1,4 +1,4 @@ | |||
| // Copyright (C) 2025-2026 Free Software Foundation, Inc. | |||
Member
There was a problem hiding this comment.
You should keep the original changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is simple, it only moves the check of unused static items and unused const items into the dead-code scan visitor.