util/attributes: Error on malformed lint attributes #4358
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasta-coder
force-pushed
the
fix/allow-malformed-4225
branch
from
e2442c7 to
a047314
Compare
Contributor
Author
|
drafted to resolve merge conflicts |
Pasta-coder
added a commit
to Pasta-coder/gccrs
that referenced
this pull request
Jan 16, 2026
Emit a diagnostic when lint attributes (allow, deny, warn, forbid) are used without arguments. Previously, these attributes were accepted silently if malformed, which could lead to confusion or ignored lints. This ensures users are informed of the expected form: #[allow(lint_name)]. Fixes Rust-GCC#4358 gcc/rust/ChangeLog: * util/rust-attributes.cc (check_lint_attribute): New helper. (AttributeChecker::visit): Call helper for lint attributes on functions. gcc/testsuite/ChangeLog: * rust/compile/allow-malformed.rs: New test. Signed-off-by: Jayant Chauhan <0001jayant@gmail.com>
Pasta-coder
force-pushed
the
fix/allow-malformed-4225
branch
from
a047314 to
f262c54
Compare
Pasta-coder
added a commit
to Pasta-coder/gccrs
that referenced
this pull request
Jan 16, 2026
Emit a diagnostic when lint attributes (allow, deny, warn, forbid) are used without arguments. Previously, these attributes were accepted silently if malformed, which could lead to confusion or ignored lints. This ensures users are informed of the expected form: #[allow(lint_name)]. Fixes Rust-GCC#4358 gcc/rust/ChangeLog: * util/rust-attributes.cc (check_lint_attribute): New helper. (AttributeChecker::visit): Call helper for lint attributes on functions. gcc/testsuite/ChangeLog: * rust/compile/issue-4225.rs: New test. Signed-off-by: Jayant Chauhan <0001jayant@gmail.com>
Pasta-coder
force-pushed
the
fix/allow-malformed-4225
branch
from
f262c54 to
c84343e
Compare
Emit a diagnostic when lint attributes (allow, deny, warn, forbid) are used without arguments. Previously, these attributes were accepted silently if malformed, which could lead to confusion or ignored lints. This ensures users are informed of the expected form: #[allow(lint_name)]. Fixes Rust-GCC#4358 gcc/rust/ChangeLog: * util/rust-attributes.cc (check_lint_attribute): New helper. (AttributeChecker::visit): Call helper for lint attributes on functions. gcc/testsuite/ChangeLog: * rust/compile/issue-4225.rs: New test. Signed-off-by: Jayant Chauhan <0001jayant@gmail.com>
Pasta-coder
force-pushed
the
fix/allow-malformed-4225
branch
from
c84343e to
4278810
Compare
Contributor
Author
|
@P-E-P please review . thankyou |
P-E-P
approved these changes
Jan 23, 2026
| // { dg-options "-w" } | ||
| #[allow] // { dg-error "malformed .allow. attribute input" } | ||
| fn foo() {} | ||
| // { dg-note "must be of the form" "" { target *-*-* } .-2 } |
Member
There was a problem hiding this comment.
Just for completeness I would add a line with a correctly formed allow attribute. Otherwise LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The lint attributes (allow, deny, warn, forbid) require arguments specifying which lints to affect. Using them without arguments (e.g. #[allow]) is invalid. This patch adds validation to reject empty lint attributes.
Fixes #4225
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog: