typecheck: Fix location and add help for E0044 foreign generics #4374
+15
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasta-coder
force-pushed
the
issue-3526
branch
from
7523921 to
b1b7baa
Compare
This patch improves the diagnostic for E0044 (foreign items with generics). Previously, the help message was missing, and the error location needed verification. Fixes Rust-GCC#3526 gcc/rust/ChangeLog: * typecheck/rust-hir-type-check-base.cc (TypeCheckBase::resolve_generic_params): Add rust_inform help message and ensure correct locus for E0044. gcc/testsuite/ChangeLog: * rust/compile/issue-3526.rs: New test. Signed-off-by: Jayant Chauhan <0001jayant@gmail.com>
Pasta-coder
force-pushed
the
issue-3526
branch
from
b1b7baa to
b6d298a
Compare
Contributor
Author
|
while looking at the refactored code i came across that the primary reason the error was misleading was that the TypeCheck pass was explicitly reading the location of the the lexer issue still exists . this doesn't not resolve issue #3526 . |
philberty
reviewed
Jan 21, 2026
| { | ||
| rust_error_at (generic_param->get_locus (), ErrorCode::E0044, | ||
| "foreign items may not have const parameters"); | ||
|
|
Member
There was a problem hiding this comment.
i think you should be using a rich_location type error for something like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3526