gccrs: fix ice on let else expession #4378
Merged
+43
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Villosse
commented
Jan 14, 2026
Villosse
force-pushed
the
4375
branch
4 times, most recently
from
0a4b15a to
5d4cf09
Compare
added error handling for let else expression. Fixes Rust-GCC#4375 gcc/rust/ChangeLog: * resolve/rust-late-name-resolver-2.0.cc (Late::visit): Visit else_expr if has_else_expr, not init_expr. Signed-off-by: lenny.chiadmi-delage <lenny.chiadmi-delage@epita.fr>
Added new tests. Addresses Rust-GCC#4375 gcc/testsuite/ChangeLog: * rust/compile/issue-4375-ice-regression.rs: New test. * rust/compile/issue-4375-multiple-errors.rs: New test. * rust/compile/issue-4375-tuple-pattern.rs: New test. Signed-off-by: lenny.chiadmi-delage <lenny.chiadmi-delage@epita.fr>
P-E-P
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4375
This PR resolve the ice on
let elseexpressionFor now, it does not follow the rustc behavior as it list all
let elserelated error instead of stopping at the first one.I also added some tests