util/attributes: handle #[export_name] on static items #4390
+56
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Emit a diagnostic when #[export_name] is used without arguments or with invalid arguments (non-string literals). This prevents silent failures or backend crashes when lowering the attribute to GIMPLE, ensuring the attribute follows the expected form: #[export_name = name]. Fixes Rust-GCC#4387 gcc/rust/ChangeLog: * util/rust-attributes.cc (check_export_name_attribute): New helper. (AttributeChecker::visit): Check export_name on functions. gcc/testsuite/ChangeLog: * rust/compile/issue-4387.rs: New test. Signed-off-by: Jayant Chauhan <[email protected]>
This patch enables validation for the #[export_name] attribute when used on static items. It reuses the validation logic introduced for functions to ensure that statics also receive compile-time checks for malformed inputs (e.g. non-string literals). Fixes Rust-GCC#4388 gcc/rust/ChangeLog: * util/rust-attributes.cc (AttributeChecker::visit): Add check for export_name on static items. gcc/testsuite/ChangeLog: * rust/compile/issue-4388.rs: New test. Signed-off-by: Jayant Chauhan <[email protected]>
Contributor
Author
|
@P-E-P please review . thankyou . |
P-E-P
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
util/attributes: handle #[export_name] on static items
This patch enables validation for the #[export_name] attribute when used
on static items. It reuses the validation logic introduced for functions
to ensure that statics also receive compile-time checks for malformed
inputs (e.g. non-string literals).
Fixes #4388
gcc/rust/ChangeLog:
gcc/testsuite/ChangeLog:
Signed-off-by: Jayant Chauhan [email protected]