derive: Implement reconstruct_path helper for cmp #4395
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch introduces a local helper to clone PathInExpression objects. This allows removing duplicate calls to , fulfilling the TODOs in EnumMatchBuilder. This ensures the self and other paths are identical without reconstructing them from strings twice. gcc/rust/ChangeLog: * expand/rust-derive-cmp-common.cc (reconstruct_path): New helper. (EnumMatchBuilder::tuple): Use reconstruct_path. (EnumMatchBuilder::strukt): Use reconstruct_path. Signed-off-by: Jayant Chauhan <[email protected]>
CohenArthur
reviewed
Jan 18, 2026
Member
CohenArthur
left a comment
CohenArthur
left a comment
There was a problem hiding this comment.
So I'm not necessarily against these changes, but the goal with this comment here was to do something like #3799 but for other base classes. I think we can merge this but I'd rather see the entire thing being implemented
Contributor
Author
|
thank you for the review . will modify accordingly . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a local helper to clone
PathInExpression objects. This allows removing duplicate calls to , fulfilling the TODOs in EnumMatchBuilder.
This ensures the self and other paths are identical without reconstructing them from strings twice.
gcc/rust/ChangeLog: