derive: Factor out Eq trait path generation #4396
Merged
+9
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pasta-coder
force-pushed
the
refactor/derive-eq-helper
branch
3 times, most recently
from
484801d to
0555ab0
Compare
CohenArthur
reviewed
Jan 18, 2026
Member
CohenArthur
left a comment
CohenArthur
left a comment
There was a problem hiding this comment.
This looks good! Thank you!
This patch introduces a local helper in DeriveEq.
This removes the duplication of the hardcoded path {core, cmp, Eq}
used in both and .
gcc/rust/ChangeLog:
* expand/rust-derive-eq.cc (get_eq_trait_path): New helper.
(DeriveEq::assert_param_is_eq): Use helper.
(DeriveEq::eq_impls): Use helper.
Signed-off-by: Jayant Chauhan <0001jayant@gmail.com>
Pasta-coder
force-pushed
the
refactor/derive-eq-helper
branch
from
0555ab0 to
b3bb087
Compare
Contributor
Author
|
@CohenArthur , thank you for the review . will also keep this in mind for future prs . |
CohenArthur
approved these changes
Jan 19, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a local helper in DeriveEq. This removes the duplication of the hardcoded path {core, cmp, Eq} used in both and .
gcc/rust/ChangeLog: