ast: Fix module path resolution for sibling modules in root

[Harishankar14]

Currently, the compiler fails to resolve module paths when a file in the root directory (e.g. 'bar.rs') attempts to load a sibling module (e.g. 'foo.rs') if a 'bar/' directory does not exist. The compiler incorrectly assumes that if 'bar.rs' is not 'mod.rs', it must look exclusively in a subdirectory.

This patch adds a fallback mechanism in 'Module::process_file_path'. If the subdirectory search fails, it strips the implicit subdirectory and attempts to resolve the module in the parent directory, consistent with Rust 2018 path rules.

Fixes #4402

gcc/rust/ChangeLog:

* ast/rust-ast.cc (Module::process_file_path): Add fallback search for sibling modules when subdirectory search fails.

gcc/testsuite/ChangeLog:

* rust/compile/issue-4402.rs: New test.
* rust/compile/issue_4402_foo.rs: New test.

Thank you for making Rust GCC better!

If your PR fixes an issue, you can add "Fixes #issue_number" into this
PR description and the git commit message. This way the issue will be
automatically closed when your PR is merged. If your change addresses
an issue but does not fully fix it please mark it as "Addresses #issue_number"
in the git commit message.

Here is a checklist to help you with your PR.

• GCC development requires copyright assignment or the Developer's Certificate of Origin sign-off, see https://gcc.gnu.org/contribute.html or https://gcc.gnu.org/dco.html
• Read contributing guidlines
• make check-rust passes locally
• Run clang-format
• Added any relevant test cases to gcc/testsuite/rust/

Note that you can skip the above if you are just opening a WIP PR in
order to get feedback.

*Please write a comment explaining your change. This is the message
that will be part of the merge commit.

[Harishankar14]

@CohenArthur

[Harishankar14]

@P-E-P ANY ISSUES , the bot removed the PR from merge queue, i guess have to make some modification accordingly with respect to your new PR that was added ?

[P-E-P]

@P-E-P ANY ISSUES , the bot removed the PR from merge queue, i guess have to make some modification accordingly with respect to your new PR that was added ?

Yes I forgot about it again; you need to add #[no_core] to the crate. If you could also rebase your branch on master and delete that merge commit that would be great.

[Harishankar14]

@P-E-P Should be GTG?

[P-E-P]

You could use something that looks like the following:

In compile.exp

set ignore_list [ "issue_4402_foo.rs" ]
dg-runtest [lsearch -inline -all -not -exact [lsort [glob -nocomplain $srcdir/$subdir/*.rs]] [ lmap file $ignore_list "$src/$subdir/$file"]] "" ""

I haven't tested it so you'll have to experiment a bit but this could do the trick

[Harishankar14]

@P-E-P I think it worked !! No failures when i tested it out locally