PublicKeyParts: provide serialization helpers #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baloo
force-pushed
the
baloo/publickeyparts/e_bytes
branch
from
a93ca2b to
b94a57c
Compare
tarcieri
reviewed
May 22, 2025
baloo
force-pushed
the
baloo/publickeyparts/e_bytes
branch
from
b94a57c to
db44475
Compare
baloo
force-pushed
the
baloo/publickeyparts/e_bytes
branch
2 times, most recently
from
2936e1d to
2664d4b
Compare
tarcieri
pushed a commit
to RustCrypto/crypto-bigint
that referenced
this pull request
May 23, 2025
…824) This helpers strips the leading zeroes from the serialization. See: - RustCrypto/RSA#519 - RustCrypto/RSA#518
tarcieri
approved these changes
May 23, 2025
When serializing the exponent or the modulus from a key, `BoxedUint::to_be_bytes` will return a slice padded with zeroes on the left because of its inner representation. Not every implementation out there will handle leading zeroes. This provides a `PublicKeyParts::n_bytes`/`e_bytes` that will strip out those leading zeros.
baloo
force-pushed
the
baloo/publickeyparts/e_bytes
branch
from
2664d4b to
fb67d6a
Compare
tarcieri
approved these changes
May 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When serializing the exponent or the modulus from a key,
BoxedUint::to_be_byteswill return a slice padded with zeroes on the left because of its inner representation. Not every implementation out there will handle leading zeroes.This provides a
PublicKeyParts::n_bytes/e_bytesthat will strip out those leading zeros.See #518 for more context.
Depends:
to_be_bytes_trimmedandto_le_bytes_trimmedforBoxedUintcrypto-bigint#824Fixes #518