Allow padding up to MAX_BLOCK_SIZE #317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Did you generate the key with PuTTYgen / KiTTY by any chance? Then it's probably #316 |
Author
That is also very possible, ive had this key for a long time and i did used to use PuTTY when on windows |
Member
|
This should have been taken care of in #316, please re-open if not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I have a problem using
russhwith myed25519ssh key.There is a check on the padding length which seems wrong, the padding is correctly formatted its just longer than the cipher block length, im not sure why its longer than 8 bytes, but it seems fair to allow padding's up to
MAX_BLOCK_SIZEas long as they are valid.The key was generated some time ago using
ssh-keygen