Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sm4: simd support for armv8, x86_64 #390

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

sm4: simd support for armv8, x86_64 #390

wants to merge 9 commits into from

Conversation

zonyitoo
Copy link

@zonyitoo zonyitoo commented Nov 3, 2023

  • x86_64: aesni, avx2
  • armv8: crypto-extension, neon

@newpavlov
Copy link
Member

Thank you! It's a relatively sizable PR, so it will take some time for us to properly review it.

@zonyitoo
Copy link
Author

Hello @newpavlov , what do you think about this PR?

@tarcieri
Copy link
Member

@zonyitoo it looks pretty impressive but as @newpavlov said it is large and because of that hard to review, especially because it contains so many backends in a single PR.

We're about to start making some breaking changes and I was looking through to see if we should land this PR first. I think it would probably make sense to try to land this as part of our next breaking release cycle. See #394

@zonyitoo
Copy link
Author

Sorry for the very very long reply since the last review. I was waiting for the final release of cipher v0.5.0, but it was still in pre-release state until now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tarcieri tarcieri tarcieri left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zonyitoo @newpavlov @tarcieri