Skip to content

Commit

Permalink
CI: bump clippy to v1.80 (#657)
Browse files Browse the repository at this point in the history
  • Loading branch information
tarcieri authored Aug 18, 2024
1 parent de72555 commit e362a47
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/crypto-bigint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ jobs:
- uses: actions/checkout@v4
- uses: dtolnay/rust-toolchain@master
with:
toolchain: 1.73.0
toolchain: 1.80.0
components: clippy
- run: cargo clippy --all --all-features -- -D warnings

Expand Down
1 change: 1 addition & 0 deletions src/modular/const_monty_form/inv.rs
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,7 @@ where
>,
{
/// Create a new [`ConstMontyFormInverter`] for the given [`ConstMontyParams`].
#[allow(clippy::new_without_default)]
pub const fn new() -> Self {
let inverter = SafeGcdInverter::new(&MOD::MODULUS, &MOD::R2);

Expand Down
6 changes: 3 additions & 3 deletions src/modular/safegcd.rs
Original file line number Diff line number Diff line change
Expand Up @@ -34,17 +34,17 @@ use subtle::CtOption;
/// - A = 1, if both the input and the expected output are in the standard form
/// - A = R^2 mod M, if both the input and the expected output are in the Montgomery form
/// - A = R mod M, if either the input or the expected output is in the Montgomery form,
/// but not both of them
/// but not both of them
///
/// The public methods of this type receive and return unsigned big integers as arrays of 64-bit
/// chunks, the ordering of which is little-endian. Both the modulus and the integer to be
/// inverted should not exceed 2 ^ (62 * L - 64).
///
/// For better understanding the implementation, the following resources are recommended:
/// - D. Bernstein, B.-Y. Yang, "Fast constant-time gcd computation and modular inversion",
/// <https://gcd.cr.yp.to/safegcd-20190413.pdf>
/// <https://gcd.cr.yp.to/safegcd-20190413.pdf>
/// - P. Wuille, "The safegcd implementation in libsecp256k1 explained",
/// <https://github.com/bitcoin-core/secp256k1/blob/master/doc/safegcd_implementation.md>
/// <https://github.com/bitcoin-core/secp256k1/blob/master/doc/safegcd_implementation.md>
#[derive(Clone, Debug)]
pub struct SafeGcdInverter<const SAT_LIMBS: usize, const UNSAT_LIMBS: usize> {
/// Modulus
Expand Down

0 comments on commit e362a47

Please sign in to comment.