Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkcs12: initial types with decoders/encoders #1165

Merged
merged 31 commits into from
Sep 8, 2023

Conversation

carl-wallace
Copy link
Contributor

  • Encoders and decoders only for PKCS 12 (decryption support and a builder will be submitted subsequently)
  • Does not support sdsiCerts or alternative CRL types
  • Copies the Pbkdf2Params and EncryptedPrivateKeyInfo definitions to avoid the lifetime requirement of the definitions in the pkcs5 crate
  • Copies the Pbes2Params definition to avoid EncryptionScheme requirement of the definition in the pkcs5 crate
  • Copies the PrivateKeyInfo definition to avoid the lifetime requirement of the definition in the pkcs8 crate
  • SafeBag is a bit unusual owing to the OR'ed list of options (this will largely be hidden behind decryption and builder support)

…crypt support to use it. added a test case with a pfx from PKITS to exercise the kdf. added implementation of EncryptedPrivateKeyInfo.
…key and cert with no mac that openssl can parse
@tarcieri
Copy link
Member

tarcieri commented Sep 5, 2023

@carl-wallace can you rebase?

@carl-wallace
Copy link
Contributor Author

I can do that first thing tomorrow.

pkcs12/src/lib.rs Outdated Show resolved Hide resolved
pkcs12/src/safe_bag.rs Outdated Show resolved Hide resolved
@tarcieri tarcieri changed the title Pkcs12 encoders and decoders pkcs12: initial types with decoders/encoders Sep 6, 2023
@tarcieri tarcieri merged commit 7191ab1 into RustCrypto:master Sep 8, 2023
172 checks passed
@carl-wallace carl-wallace deleted the pkcs12_encoder_decoder branch September 11, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants