Bump digest to v0.11.0-pre.3; MSRV 1.71#523
Merged
Conversation
Also bumps crate editions to 2021 where appropriate
tarcieri
changed the title
digest to v0.11.0-pre; MSRV 1.65digest to v0.11.0-pre.1; MSRV 1.65
tarcieri
force-pushed
the
digest/v0.11.0-pre
branch
from
0c342cb to
fbd933f
Compare
tarcieri
changed the title
digest to v0.11.0-pre.1; MSRV 1.65digest to v0.11.0-pre.2; MSRV 1.65
newpavlov
reviewed
Jan 4, 2024
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
You forgot to update MSRV in a number of crate readmes.
| // SAFETY: Array<u8, U64> and [u8; 64] have | ||
| // exactly the same memory layout | ||
| let p = blocks.as_ptr() as *const [u8; BLOCK_SIZE]; | ||
| unsafe { core::slice::from_raw_parts(p, blocks.len()) } |
Member
There was a problem hiding this comment.
It could be worth to remove unsafe lines like this by adding a conversion method to the ArrayOps trait.
Member
Author
There was a problem hiding this comment.
Let's save that for a followup, but I agree
| //! hasher.update(b"hello world"); | ||
| //! | ||
| //! // acquire hash digest in the form of GenericArray, | ||
| //! // acquire hash digest in the form of Array, |
Member
There was a problem hiding this comment.
Suggested change
| //! // acquire hash digest in the form of Array, | |
| //! // acquire hash in the form of `hybrid_array::Array`, |
| extern crate test; | ||
|
|
||
| use digest::{bench_update, generic_array::typenum::U64}; | ||
| use digest::{array::typenum::U64, bench_update}; |
Member
There was a problem hiding this comment.
Suggested change
| use digest::{array::typenum::U64, bench_update}; | |
| use digest::{typenum::U64, bench_update}; |
| extern crate test; | ||
|
|
||
| use digest::{bench_update, generic_array::typenum::U32}; | ||
| use digest::{array::typenum::U32, bench_update}; |
Member
There was a problem hiding this comment.
Suggested change
| use digest::{array::typenum::U32, bench_update}; | |
| use digest::{typenum::U32, bench_update}; |
| extern crate test; | ||
|
|
||
| use digest::{bench_update, generic_array::typenum::U128}; | ||
| use digest::{array::typenum::U128, bench_update}; |
Member
There was a problem hiding this comment.
Suggested change
| use digest::{array::typenum::U128, bench_update}; | |
| use digest::{typenum::U128, bench_update}; |
| //! hasher.update(b"hello world"); | ||
| //! | ||
| //! // acquire hash digest in the form of GenericArray, | ||
| //! // acquire hash digest in the form of Array, |
Member
There was a problem hiding this comment.
Suggested change
| //! // acquire hash digest in the form of Array, | |
| //! // acquire hash in the form of `hybrid_array::Array<u8, U16>`, |
| use crate::compressor::Compressor; | ||
| use core::fmt; | ||
| use digest::{ | ||
| array::typenum::{Unsigned, U28, U32, U48, U64}, |
Member
There was a problem hiding this comment.
Suggested change
| array::typenum::{Unsigned, U28, U32, U48, U64}, | |
| typenum::{Unsigned, U28, U32, U48, U64}, |
| //! hasher.update(b"my message"); | ||
| //! | ||
| //! // acquire hash digest in the form of GenericArray, | ||
| //! // acquire hash digest in the form of Array, |
Member
There was a problem hiding this comment.
Suggested change
| //! // acquire hash digest in the form of Array, | |
| //! // acquire hash in the form of `hybrid_array::Array<u8, U32>`, |
| //! hasher.update("The quick brown fox jumps over the lazy dog"); | ||
| //! | ||
| //! // acquire hash digest in the form of GenericArray, | ||
| //! // acquire hash digest in the form of Array, |
Member
There was a problem hiding this comment.
Suggested change
| //! // acquire hash digest in the form of Array, | |
| //! // acquire hash in the form of `hybrid_array::Array<u8, U32>`, |
| //! hasher.update(b"hello world"); | ||
| //! | ||
| //! // acquire hash digest in the form of GenericArray, | ||
| //! // acquire hash digest in the form of Array, |
Member
There was a problem hiding this comment.
Suggested change
| //! // acquire hash digest in the form of Array, | |
| //! // acquire hash in the form of `hybrid_array::Array<u8, U32>`, |
tarcieri
changed the title
digest to v0.11.0-pre.2; MSRV 1.65digest to v0.11.0-pre.3; MSRV 1.71
tarcieri
force-pushed
the
digest/v0.11.0-pre
branch
from
fbd933f to
6fd20b4
Compare
tarcieri
force-pushed
the
digest/v0.11.0-pre
branch
from
6fd20b4 to
794bd1e
Compare
newpavlov
approved these changes
Jan 6, 2024
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
I will do a follow-up PR a bit later.
tarcieri
added a commit
that referenced
this pull request
Jan 6, 2024
The new MSRV after #523 is 1.71
tarcieri
added a commit
that referenced
this pull request
Jan 6, 2024
The new MSRV after #523 is 1.71
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also bumps crate editions to 2021 where appropriate