Add Borrow<Array<T, _>>/BorrowMut impls for [T; N]
#134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provides an alternative to #133 using the less commonly used `Borrow` trait instead, which should still make the same patterns of exposing APIs with core arrays possible, but hopefully while causing less breakage in end user code.
tarcieri
force-pushed
the
add-borrow-impls-for-core-arrays
branch
from
1f293a9 to
b81b313
Compare
tarcieri
changed the title
Borrow<Array<_, _>>/BorrowMut impls for [T; N]Borrow<Array<T, _>>/BorrowMut impls for [T; N]
|
@kayabaNerve I tried this out on your code and everything seems fine. I expect since |
|
I probably should've posted a potential alternative, which would be to modify the |
tarcieri
added a commit
that referenced
this pull request
Sep 1, 2025
Impl'd for `Array<T, U>` and `[T; N]`. This is an alternative to #134, given the trouble we had in #131 with adding impls of core traits to `[T; N]` and the ensuing inference conflicts it can cause. The safest thing we can do is define our own traits, and these traits bound on `AssocArraySize` so they're able to handle everything related to the array size themselves, making them generic around only `T`. With this we can revert #134, which still has the potential to cause problems similar to #131. Using our own trait guarantees we won't break inference in existing code.
tarcieri
added a commit
that referenced
this pull request
Sep 1, 2025
Impl'd for `Array<T, U>` and `[T; N]`. This is an alternative to #134, given the trouble we had in #131 with adding impls of core traits to `[T; N]` and the ensuing inference conflicts it can cause. The safest thing we can do is define our own traits, and these traits bound on `AssocArraySize` so they're able to handle everything related to the array size themselves, making them generic around only `T`. With this we can revert #134, which still has the potential to cause problems similar to #131. Using our own trait guarantees we won't break inference in existing code.
tarcieri
added a commit
that referenced
this pull request
Sep 1, 2025
Impl'd for `Array<T, U>` and `[T; N]`. This is an alternative to #134, given the trouble we had in #131 with adding impls of core traits to `[T; N]` and the ensuing inference conflicts it can cause. The safest thing we can do is define our own traits, and these traits bound on `AssocArraySize` so they're able to handle everything related to the array size themselves, making them generic around only `T`. With this we can revert #134, which still has the potential to cause problems similar to #131. Using our own trait guarantees we won't break inference in existing code.
tarcieri
added a commit
that referenced
this pull request
Sep 1, 2025
Impl'd for `Array<T, U>` and `[T; N]`. This is an alternative to #134, given the trouble we had in #131 with adding impls of core traits to `[T; N]` and the ensuing inference conflicts it can cause. The safest thing we can do is define our own traits, and these traits bound on `AssocArraySize` so they're able to handle everything related to the array size themselves, making them generic around only `T`. With this we can revert #134, which still has the potential to cause problems similar to #131. Using our own trait guarantees we won't break inference in existing code.
tarcieri
added a commit
that referenced
this pull request
Sep 1, 2025
tarcieri
added a commit
that referenced
this pull request
Sep 1, 2025
|
I do have some code that uses Using hybrid-array traits also sounds perfect, but I'll leave it to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides an alternative to #133 using the less commonly used
Borrowtrait instead, which should still make the same patterns of exposing APIs with core arrays possible, but hopefully while causing less breakage in end user code.