Reduce rust-version #487
Closed
Reduce rust-version #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Force-pushed to also set the MSRV for the CI. |
|
And force-pushed again to also change it in the tests, as well as the docs. |
|
The main reason was to leave the door open to using GATs as part of a solution to #380, though granted no progress was made on that problem. There's a high burden to maintaining older MSRVs in terms of dependency incompatibilities and overall project toil in that regard, longer compile times due to slower older compilers, and locking ourselves out of Rust features, and our upgrade cycles run quite long, so I'm just going to close this as I would prefer to upgrade, not downgrade, from MSRVs we commit to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a reason why rust-version for argon2 was at 1.65? I'm compiling with rustc 1.63.0 from Debian bookworm, it compiled fine and I haven't seen any issues at runtime. The increase from 1.60 was done as part of #391 but I couldn't see a reasoning and it was done for the main Cargo.toml as well, maybe it was only relevant for the main crate.