Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lms: fix size of otstype #875

Merged
merged 2 commits into from
Dec 10, 2024
Merged

Conversation

davidthomaswood
Copy link
Contributor

otstype is converted as a u32 below, panics if it is ID_LEN (16) bytes long. With this change, the SigningKey can be correctly converted to bytes and back.

`otstype` is converted as a `u32` below, panics if it is `ID_LEN` (16) bytes long. With this change, the `SigningKey` can be correctly converted to bytes and back.
@tarcieri tarcieri changed the title Fix size of otstype lms: fix size of otstype Nov 12, 2024
@tarcieri
Copy link
Member

cc @incertia

Copy link
Contributor

@incertia incertia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops I just saw this. looks like a bug in the original implementation.

@tarcieri tarcieri merged commit dff009f into RustCrypto:master Dec 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants