Skip to content

Add lifetime to CustomizedExtArg #1561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Add lifetime to CustomizedExtArg #1561

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions digest/src/core_api/wrapper.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,15 +165,15 @@ impl<T> CustomizedInit for CoreWrapper<T>
where
T: BufferKindUser + CustomizedInit,
{
type CustomizedExtArg = T::CustomizedExtArg;
type CustomizedExtArg<'a> = T::CustomizedExtArg<'a>;

#[inline]
fn new_customized(customization: &[u8]) -> Self {
Self::from_core(T::new_customized(customization))
}

#[inline]
fn new_ext_customized(customization_ext: &Self::CustomizedExtArg) -> Self {
fn new_ext_customized(customization_ext: &Self::CustomizedExtArg<'_>) -> Self {
Self::from_core(T::new_ext_customized(customization_ext))
}
}
Expand Down
4 changes: 2 additions & 2 deletions digest/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,13 +274,13 @@ pub trait CustomizedInit: Sized {
// associated type defaults are currently unstable

/// Extended customization
type CustomizedExtArg;
type CustomizedExtArg<'a>;

/// Create new hasher instance with the given customization string.
fn new_customized(customization: &[u8]) -> Self;

/// Create new hasher instance with the given extended customization.
fn new_ext_customized(customization_ext: &Self::CustomizedExtArg) -> Self;
fn new_ext_customized(customization_ext: &Self::CustomizedExtArg<'_>) -> Self;
}

/// The error type used in variable hash traits.
Expand Down