Investigate missing storybook stories #130
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ryanclementshax <[email protected]>
|
Cursor Agent can help with this pull request. Just |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
🚦 Running Lighthouse audit on mobile... |
|
🚦 Running Lighthouse audit on desktop... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Storybook config to ESM and fix stories glob pattern for Storybook 9 compatibility.
The previous
storiesglob pattern used an extglob (!(node_modules)) which is not supported by Storybook 9'sfast-globlibrary, causing no stories to be discovered. The updated pattern is compatible, and Storybook 9 automatically ignoresnode_modules. The configuration was also updated to an ESM default export, which is the preferred style for Storybook 9.