Entered the measurements of the SAM masks of ERIS into get_infos_obs.py. #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please note that the two cameras within ERIS are misaligned w.r.t each other, which is why there are two measurements for each SAM mask: one for each of the camera (JHK or LM).
for more information, see https://pre-commit.ci
Added a function to compute the position angle for ERIS based on simple linear interpolation between the start and end parallactic angles, and taking into account the pupil angle.
for more information, see https://pre-commit.ci
Collaborator
|
Hi @JHayoz, Thanks for implementing the ERIS compatibility into AMICAL. Everything looks good! Did you test your branch on an actual dataset? Also, we recommend including some appropriate tests (using pytest) for any new features (or instruments in your case). See contributing.md. If you have some public dataset you want to test on, we can work to generate an example script (as for VLT/SPHERE). Let me know what you want to do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please note that the two cameras within ERIS are misaligned w.r.t each other, which is why there are two measurements for each SAM mask: one for each of the camera (JHK or LM).