Conversation
|
@MrShubham22 please send the secret to me via Teams |
done |
chgeo
left a comment
There was a problem hiding this comment.
2 things from my side:
Lots of redundancies between the Node and Java scripts. Have you thought about reusing common parts? See e.g. how CF deployment reuses code through actions.
Lots of lengthy 'progress log', which should be avoided. Especially docker, and curl cause this. Check for options in these tools that hide progress output. I have done this already for mvn via its -B parameter.
Sure will look into that , Thanks |
uwe-klinger
left a comment
There was a problem hiding this comment.
Ok, from testing perspective. Please see Christian's comments.
tried moving the common docker login and setting up env part of a diff workflow but docker login and kubeconfig export and whatever setup we do , the context of it gets lost when we come back to the called workflow and based on that login and kubeconfig exported file we're pushing images. |
also yes i'm looking for -quiet verbose for the cli commands wehrever possible |
DOCKER_PASSWORD github secret in this repo needs to be changed for the e2e tests to work