fix: [Orchestration] spec update #460
Conversation
…eaming-response-type
| import javax.annotation.Nonnull; | ||
| import javax.annotation.Nullable; | ||
| import lombok.val; | ||
|
|
||
| /** Orchestration chat completion output delta for streaming. */ | ||
| public class OrchestrationChatCompletionDelta extends CompletionPostResponse | ||
| public class OrchestrationChatCompletionDelta extends CompletionPostResponseStreaming |
There was a problem hiding this comment.
Accepted breaking change, very minor
orchestration/src/test/java/com/sap/ai/sdk/orchestration/OrchestrationModuleConfigTest.java
Show resolved
Hide resolved
orchestration/src/main/java/com/sap/ai/sdk/orchestration/model/DPIEntityConfig.java
Outdated
Show resolved
Hide resolved
…onse-type # Conflicts: # orchestration/src/main/java/com/sap/ai/sdk/orchestration/DpiMasking.java
Co-authored-by: Roshin Rajan Panackal <[email protected]>
|
Should embedding endpoint already be public for the next sdk release? |
…ffix and Embedding property renaming (#469) * Introduce filtering schema changes and update generated class names - synchronous suffix removed - `createConfig` removed from `ContentFilter` - release notes updated for filtering changes * Introduce filtering schema changes and update generated class names - synchronous suffix removed - `createConfig` removed from `ContentFilter` - release notes updated for filtering changes * Release notes and jacoco coverage work around * Lower min required jacoco coverage complexity and branch rating. - Release note paraphrasing * Update e2e for input filters --------- Co-authored-by: Roshin Rajan Panackal <[email protected]>
Ans:
Checkout the discussion here, Embedding models are left unchanged and client endpoint is package private |
…onse-type # Conflicts: # docs/release_notes.md # orchestration/pom.xml # orchestration/src/main/java/com/sap/ai/sdk/orchestration/JacksonMixins.java # sample-code/spring-app/src/test/java/com/sap/ai/sdk/app/controllers/OrchestrationTest.java
| */ | ||
| @Nonnull | ||
| FilterConfig createConfig(); | ||
| InputFilterConfig createInputFilterConfig(); |
There was a problem hiding this comment.
(Comment)
While I agree to the solution, it doesn't feel great that we're changing public API on convenience layer. That would be considered a breaking change normally. I do understand we only use it as workaround to expose the low-level converter method(s), but still.. 🤔
There was a problem hiding this comment.
I would have blocked the generation entirely until they reverted the spec, but I was on vacation and you accepted the breaking change. I'm still in favor of blocking future changes that don't compile.
|
If you merge the spec from Confirmed by Christoph. |
Context
AI/ai-sdk-java-backlog#448.
Update to the latest spec from orchestration from this branch
Feature scope:
synchronousandstreaminginstead of aoneofDefinition of Done
Aligned changes with the JavaScript SDK