refactor: 💡 [HCPSDKFIORIUIKIT-2679] InfoViewModel #1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
billzhou0223
requested changes
Apr 28, 2025
| /// ``` | ||
| // sourcery: CompositeComponent | ||
| protocol _InfoViewComponent: _TitleComponent, _DescriptionTextComponent, _ActionComponent, _SecondaryActionComponent { | ||
| var loadingIndicator: LoadingIndicator? { get set } |
There was a problem hiding this comment.
Should this property be a view builder so that developers can customize it?
I think we should provide a default indicator as well.
There was a problem hiding this comment.
I have updated the code based on all the suggestions and added UT. Thank you all @billzhou0223 @dyongxu @janhuachu
dyongxu
reviewed
Apr 28, 2025
Sources/FioriSwiftUICore/_ComponentProtocols/CompositeComponentProtocols.swift
Outdated
Show resolved
Hide resolved
dyongxu
reviewed
Apr 28, 2025
Sources/FioriSwiftUICore/_ComponentProtocols/CompositeComponentProtocols.swift
Show resolved
Hide resolved
|
@leoxiao-sap Pls add unit test as well |
dyongxu
approved these changes
Apr 29, 2025
dyongxu
requested changes
Apr 29, 2025
Done, thanks |
refactor: 💡 [HCPSDKFIORIUIKIT-2679] InfoViewModel #
dyongxu
approved these changes
Apr 30, 2025
|
@billzhou0223 Pls review again if your comments are addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dev results:
