Skip to content

fix: 🐛 [IOSSDKBUG-991] revert segment control style in swift5 #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: 🐛 [IOSSDKBUG-991] revert segment control style in swift5 #1303

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e257c56
fix: 🐛 [IOSSDKBUG-991] revert segment control style in swift5
xiaoyu0722 Oct 22, 2025
e2cbf6f
Merge branch 'main' into fix-IOSSDKBUG-991
dyongxu Oct 22, 2025
db87030
fix: 🐛 stop style update if liquid glass is disabled in iOS 26
xiaoyu0722 Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions Apps/Examples/Examples/FioriSwiftUICore/Picker/SegmentedControlExample.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,15 @@ struct SegmentedControlExample: View {
}

var borderShape: some Shape {
if #available(iOS 26.0, *) {
return Capsule()
} else {
#if swift(>=6.0)
if #available(iOS 26.0, *) {
return Capsule()
} else {
return RoundedRectangle(cornerRadius: 9)
}
#else
return RoundedRectangle(cornerRadius: 9)
}
#endif
}
}

Expand Down
12 changes: 8 additions & 4 deletions Sources/FioriSwiftUICore/_FioriStyles/SegmentedControlPickerStyle.fiori.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,11 +52,15 @@ extension SegmentedControlPickerFioriStyle {
}

var borderShape: some Shape {
if #available(iOS 26.0, *) {
return Capsule()
} else {
#if swift(>=6.0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our SDK is using Swift compiler 5.9. (See Package.swift, the first line)
Mobile Start team consumes it as binary framework(not source code)

That means, our binary framework will always return RoundedRectangle(cornerRadius: 9) at line 62. No capsule will be returned at all.
For Mobile Start team, even if they use Swift compiler 6.0, they will not reach the "if" side of the code.

if #available(iOS 26.0, *) {
return Capsule()
} else {
return RoundedRectangle(cornerRadius: 9)
}
#else
return RoundedRectangle(cornerRadius: 9)
}
#endif
}
}

Expand Down
Loading