fix: 🐛 IOSSDKBUG-347 layout incorrect for lots of filter items #832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dyongxu
requested review from
billzhou0223 and
xiaoqinggracehe
and removed request for
a team
xiaoqinggrace
approved these changes
Oct 23, 2024
billzhou0223
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pletanek, Jiri reopened https://jira.tools.sap/browse/IOSSDKBUG-347, with a concern for
If the number of picker values is high (I don't know the limit), the picker is useless since it cannot be applied (header and apply button are missing, the sheet is not even scrollable). Please see attached screenshots.
This PR is to fix the above issue.
After the fix
