Skip to content

fix: 🐛 [IOSSDKBUG-416]FilterFeedbackBar on iPad layout #835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2024

Conversation

restaurantt
Copy link
Collaborator

Adapt the layout of FilterFeedbackBarItem's popover view on iPad.
Arrow direction is decided by system on iPad.
iOS 17.4:
17 Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-10-25 at 11 27 17
17 Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-10-25 at 11 27 56
iOS 18.0:
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-10-25 at 11 26 20
Simulator Screenshot - iPad Pro 13-inch (M4) - 2024-10-25 at 11 26 35
Simulator Screenshot - iPhone 16 Plus - 2024-10-25 at 11 25 40
Simulator Screenshot - iPhone 16 Plus - 2024-10-25 at 11 25 56

@restaurantt restaurantt requested a review from a team as a code owner October 25, 2024 04:22
@restaurantt restaurantt requested review from billzhou0223 and removed request for a team October 25, 2024 04:22
Copy link
Contributor

@dyongxu dyongxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need cherrypick to rel-4.1 @restaurantt

@dyongxu dyongxu merged commit e7257b1 into SAP:main Oct 25, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants