fix: 🐛 IOSSDKBUG-430 Fiori FilterFeedbackBar enhancement #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature change request for showing the label when there is a single item selected.
xiaoqinggrace
requested review from
billzhou0223
and removed request for
a team
billzhou0223
requested changes
Oct 31, 2024
dyongxu
reviewed
Oct 31, 2024
dyongxu
reviewed
Oct 31, 2024
dyongxu
reviewed
Oct 31, 2024
dyongxu
requested changes
Oct 31, 2024
dyongxu
reviewed
Oct 31, 2024
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| /// Enum for display mode of the FilterFeedbackBar item when only one value is selected for that item. | ||
| /// This is effective, regardless of that item allowing multiple selection or not | ||
| /// The default value is `.name`. | ||
| public enum BarItemDisplayMode { |
There was a problem hiding this comment.
Nesting Violation: Types should be nested at most 1 level deep (nesting)
dyongxu
approved these changes
Nov 1, 2024
billzhou0223
approved these changes
Nov 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature change request for showing the label when there is a single item selected.
Based on the requirement, change the showsValueForSingleSelected to singleSelectedMode. This will allow the Filter Feedback Bar label to show the name, value, or name and value when a single item is selected.
In the following screenshot, the 2nd, 3rd, and 4th cells are set as show name, show value, and show name and value.