feat: Support basePath in options-per-service for openapi generator
#5311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… - Option 2 (#5247) * chore: append basePath to path pattern in openapi generator * chore: switch to using removeSlashes from util * chore: add additional test * chore: check-public-api change * Changes from lint:fix * chore: update test * chore: adjust all tests * chore: fix codeQL warning * Changes from lint:fix * chore: add changeset * chore: cleanup tests * feat: extend openapi request builder for basePath * chore: introduce setBasePath * feat: introduce _defaultBasePath to the generated files * chore: fix order of parameters with intro of basepath * chore: fix tests * chore: add setBasePath * chore: fix failing e2e test * Changes from lint:fix * chore: cleanup path * Changes from lint:fix * chore: adjust test * Changes from lint:fix * chore: switch to using undefined for default basePath value * chore: cleanup test * chore: update changeset * chore: adjust changeset * chore: fix unit test * chore:cleanup * chore: fix test * chore: cleanup changesets * fix: integration test * chore: fix path * chore:fix path * chore: remove dead code * chore: review comment * Update .changeset/chilled-flowers-hide.md Co-authored-by: Deeksha Sinha <[email protected]> * Update packages/openapi/src/openapi-request-builder.ts Co-authored-by: Deeksha Sinha <[email protected]> * chore: address review comments * chore: revert update to removeSlashes utility * Changes from lint:fix * chore: address review comments * chore: tests fix * chore: adjust tests * chore: address review comments * Changes from lint:fix * fix: begin all paths using '/' * chore: address review comments * Update .changeset/chilled-flowers-hide.md Co-authored-by: Deeksha Sinha <[email protected]> * Update .changeset/chilled-flowers-freeze.md Co-authored-by: Deeksha Sinha <[email protected]> * Update packages/util/src/remove-slashes.spec.ts Co-authored-by: Deeksha Sinha <[email protected]> * Update packages/util/src/remove-slashes.spec.ts Co-authored-by: Deeksha Sinha <[email protected]> * chore: address review comments * Changes from lint:fix * chore: add review changes * chore: address review comments * chore:address review comments * chore: address review comments * chore: release note fix --------- Co-authored-by: cloud-sdk-js <[email protected]> Co-authored-by: Junjie Tang <[email protected]> Co-authored-by: Deeksha Sinha <[email protected]>
KavithaSiva
changed the title
basePath in options-per-service for openapi generator…basePath in options-per-service for openapi generator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked commit for PR - #5247
v3-mainnow, which is not for v4 development.- [ ] If my change will be merged into themainbranch (for v4), I've updated (V4-Upgrade-Guide.md)[./V4-Upgrade-Guide.md] in case my change has any implications for users updating to SDK v4