Remove new X5tCertificateThumbprintValidator from spring-xsuaa module #1579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
liga-oz
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
spring-security has added a new x5t certificate thumbprint validator to the list of default validators:
spring-projects/spring-security@644cfa9#diff-a4724ab787f6f0344a9ab4d3d8f1ce9b0cd16f0b24a51d497b3290b41ed43a04R70-R73
This new validator is automatically getting used in the XsuaaJwtDecoder of the spring-xsuaa module of this lib once consumers update to a newer spring-security version.
This validator does not work for typical usage scenarios of this lib without further configuration because it expects a client certificate in the request. As TLS termination is done earlier by BTP and the certificate is instead forwarded in a header that is not used by the new validator, it will always fail to find a certificate for the validation.
To restore the previous functionality of the spring-xsuaa module, which is in maintenance mode, I am explicitly importing only the previous default validator(s) instead which happens to be only a timestamp validator.