feat: add recreateOnSubscriptionFailure field to Subscription resource #205
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gergely-szabo-sap
requested a deployment
to
pr-e2e-approval
GitHub Actions
Waiting
gergely-szabo-sap
force-pushed
the
178-feature-reconcile-recreate-subscription-on-subscribe_failed
branch
from
ccf5094 to
ba0e6c9
Compare
gergely-szabo-sap
temporarily deployed
to
pr-e2e-approval
GitHub Actions
Inactive
sdischer-sap
approved these changes
Jun 30, 2025
| @@ -268,6 +271,116 @@ func TestCreate(t *testing.T) { | |||
| } | |||
| } | |||
|
|
|||
| func TestRecreateOnFailed(t *testing.T) { | |||
There was a problem hiding this comment.
I like this idea of testing the whole flow in integration here. Makes it more clear what the indented behaviour really is.
|
@gergely-szabo-sap just one request. Could you please fill the PR description a little. Just for future reference. Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.