Skip to content

refactor(versioning): reduce if complexity #5343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

refactor(versioning): reduce if complexity #5343

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a47c03c
refactor(versioning): reduce if complexity
CCFenner Apr 30, 2025
2524e3f
Update artifactPrepareVersion.go
CCFenner Apr 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions cmd/artifactPrepareVersion.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,12 @@ func runArtifactPrepareVersion(config *artifactPrepareVersionOptions, telemetryD

// we may replace GetVersion() above with GetCoordinates() at some point ...
coordinates, err := artifact.GetCoordinates()
if err != nil && !config.FetchCoordinates {
log.Entry().Warnf("fetchCoordinates is false and failed get artifact Coordinates")
} else if err != nil && config.FetchCoordinates {
return fmt.Errorf("failed to get coordinates: %w", err)
if err != nil {
if config.FetchCoordinates {
return fmt.Errorf("failed to get artifact coordinates: %w", err)
} else {
log.Entry().Warnf("failed to get artifact Coordinates: ignoring as fetchCoordinates is false")
}
} else {
commonPipelineEnvironment.artifactID = coordinates.ArtifactID
commonPipelineEnvironment.groupID = coordinates.GroupID
Expand Down
Loading