fix: escape path in maven when user inputs a space #5346
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -546,7 +546,7 @@ func addDetectArgs(args []string, config detectExecuteScanOptions, utils detectU | |||
| args = append(args, fmt.Sprintf("\"--detect.code.location.name=%v\"", codelocation)) | |||
|
|
|||
| if len(mavenArgs) > 0 && !checkIfArgumentIsInScanProperties(config, "detect.maven.build.command") { | |||
| args = append(args, fmt.Sprintf("\"--detect.maven.build.command=%v\"", strings.Join(mavenArgs, " "))) | |||
There was a problem hiding this comment.
Cant users escape the space in path?
|
|
||
| func quoteMavenArgs(args []string) string { | ||
| // Quote any argument containing spaces to handle paths properly | ||
| quotedArgs := make([]string, len(args)) |
There was a problem hiding this comment.
Does this work in all platforms and cases?
There was a problem hiding this comment.
We don't own this step :)
|
|
/it |
CCFenner
reviewed
May 14, 2025
| } | ||
|
|
||
| for _, test := range tt { | ||
| test := test |
There was a problem hiding this comment.
What is the use of this directive?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User reported issues when a maven path contains a space. This PR wraps such paths in single quotes.
Checklist