Skip to content

Conversation

@lekuehn
Copy link

@lekuehn lekuehn commented Dec 22, 2025

Description

Using the getConfig step as part of the SAP/project-piper-action to retrieve the step configuration for an (enterprise) step:

    - name: Read step configuration
      uses: SAP/[email protected]
      with:
        step-name: getConfig
        flags: >-
          --stepName <my-step-name>
          --outputFile step-config.json

does not resolve vault credentials since the invocation of the Vault client within GetStepConfig (see here) will be skipped since the Vault credentials aren't set.
Usually, setting the Vault credentials is done within the PrepareConfig function within each _generated.go file but the getConfig step does not have such a file. Therefore, we need to add this logic here as well.

We are open for any discussions about other ways to achieve our goal. Feel free to reach out.

Checklist

  • Tests
  • Documentation
  • Inner source library needs updating

@lekuehn lekuehn requested a review from a team as a code owner December 22, 2025 10:46
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants