refactor: Enhance XML Fragment context menu control with addXMLPlugin Integration #3091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 998384e The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmilko01
changed the title
mmilko01
changed the title
voicis
reviewed
Apr 8, 2025
…pen-ux-tools into feat/consume-addxml-plugin
…pen-ux-tools into feat/consume-addxml-plugin
testojs
previously approved these changes
Apr 23, 2025
Contributor
testojs
left a comment
testojs
left a comment
There was a problem hiding this comment.
- change looks good
- changeset OK
- good test coverage
- did not tested manually
voicis
suggested changes
Apr 23, 2025
packages/preview-middleware-client/test/unit/adp/add-fragment.test.ts
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/adp/controllers/AddFragment.controller.ts
Show resolved
Hide resolved
packages/preview-middleware-client/src/cpe/additional-change-info/add-xml-additional-info.ts
Show resolved
Hide resolved
packages/preview-middleware-client/src/adp/controllers/AddFragment.controller.ts
Show resolved
Hide resolved
voicis
reviewed
Apr 24, 2025
packages/preview-middleware-client/test/unit/adp/controllers/AddFragment.controller.test.ts
Outdated
Show resolved
Hide resolved
voicis
reviewed
Apr 24, 2025
packages/preview-middleware-client/src/flp/enableFakeConnector.ts
Outdated
Show resolved
Hide resolved
...eview-middleware-client/test/unit/cpe/additional-change-info/add-xml-additional-info.test.ts
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/test/unit/utils/additional-change-info.test.ts
Outdated
Show resolved
Hide resolved
packages/preview-middleware-client/src/utils/additional-change-info.ts
Outdated
Show resolved
Hide resolved
voicis
approved these changes
Apr 24, 2025
Contributor
voicis
left a comment
voicis
left a comment
There was a problem hiding this comment.
- Good test coverage
- Review comments addressed
- Tested manually
|
avasilev-sap
pushed a commit
that referenced
this pull request
May 14, 2025
… Integration (#3091) * feat: consume AddXMLPlugin * fix: set default plugins * fix: set default plugins * feat: consume ExtendController plugin * fix: types * fix: controller extension handler function * chore: temporary disabled unit tests * feat: consume addXMLPlugin * fix: add removed empty line * fix: change required ui5 version * Linting auto fix commit * chore: create changeset * test: add missing rta method * test: enabled table columns tests * fix: remove unneeded subscribe function * fix: remove unneeded imports * fix: wrong return type * refactor: static methods in AddFragmentService class * fix: remove unneeded action * test: stabilize current tests * test: add tests for add-fragment * test: enhance init-dialogs tests * fix: ehnahce AddFragment controlle tests * test: uncovered branches * chore: remove changeset module * chore: update changeset description * fix: pass templateName to plugin * refactor: simplify add-fragment * fix: remove unneeded variable * fix: cycling dependency * refactor: create extended change object and set it in Session Storage * fix: return type * refacor: move additional info in utils * fix: return type * fix: rename parameters * test: stabilize current tests * fix: lint issues * fix: get additional change info in connector service * fix: lint issues * refactor: use map instead of sessionStorage * test: fix tests * test: add coverage * fix: sonar issue * fix: review comments * chore: update patchset * fix: address review comments * fix: wrong class name * test: fix mock * fix: address review comments * test: remove unneeded mocks --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3093
addXMLPluginis used.