-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escape slashes in entity keys when they appear in the URL path #284
base: master
Are you sure you want to change the base?
Conversation
CHANGELOG.md
Outdated
@@ -5,7 +5,8 @@ The format is based on [Keep a Changelog](http://keepachangelog.com/) | |||
and this project adheres to [Semantic Versioning](http://semver.org/). | |||
|
|||
## [Unreleased] | |||
|
|||
### Fixed | |||
- Escape slashes in entity keys when they appear in the URL path |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: if you see the changelog entries, we add also author names for important changes. So feel free to add yourself to this line :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding my name for the fame and fortune!
HI @frij-aws thank you for your work. Generic stuff I commented in the issue, here just what's relevant to the code changes. Nothing existing in the test suite is changed or broken, that's great. If I may, I would like to ask you to enhance bit the test code.
|
Pyodata does not correctly escape the path when an entity key contains a /. This minor correction quotes the entity key with
safe=""
to ensure slashes are quoted. The rest of the path is quoted with the default (`safe='/') so that path delimiters are not quoted.Closes #282